ti.sil/sourcebot
1
0
Fork 0
mirror of https://github.com/sourcebot-dev/sourcebot.git synced 2025-12-12 04:15:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
sourcebot/packages/shared
History
Brendan Kellam 22d548e171
fix(search-contexts): Fix issue where a repository would not appear in a search context if it was created after the search context was created (#354) 
## Problem

If a repository is added **after** a search context (e.g., a new repository is synced from the code host), then it will never be added to the context even if it should be included. The workaround is to restart the instance.

## Solution

This PR adds a call to re-sync all search contexts whenever a connection is successfully synced. This PR adds the `@sourcebot/shared` package that contains `syncSearchContexts.ts` (previously in web) and it's dependencies (namely the entitlements system).

## Why another package?

Because the `syncSearchContexts` call is now called from:
1. `initialize.ts` in **web** - handles syncing search contexts on startup and whenever the config is modified in watch mode. This is the same as before.
2. `connectionManager.ts` in **backend** - syncs the search contexts whenever a connection is successfully synced.

## Follow-up devex work
Two things:
1. We have several very thin shared packages (i.e., `crypto`, `error`, and `logger`) that we can probably fold into this "general" shared package. `schemas` and `db` _feels_ like they should remain separate (mostly because they are "code-gen" packages).
2. When running `yarn dev`, any changes made to the shared package will only get picked if you `ctrl+c` and restart the instance. Would be nice if we have watch mode work across package dependencies in the monorepo.
2025-06-17 14:04:25 -07:00
..
src fix(search-contexts): Fix issue where a repository would not appear in a search context if it was created after the search context was created (#354) 2025-06-17 14:04:25 -07:00
.gitignore fix(search-contexts): Fix issue where a repository would not appear in a search context if it was created after the search context was created (#354) 2025-06-17 14:04:25 -07:00
package.json fix(search-contexts): Fix issue where a repository would not appear in a search context if it was created after the search context was created (#354) 2025-06-17 14:04:25 -07:00
README.md fix(search-contexts): Fix issue where a repository would not appear in a search context if it was created after the search context was created (#354) 2025-06-17 14:04:25 -07:00
tsconfig.json fix(search-contexts): Fix issue where a repository would not appear in a search context if it was created after the search context was created (#354) 2025-06-17 14:04:25 -07:00

README.md

This package contains shared code between the backend & webapp packages.

Why two index files?

This package contains two index files: index.server.ts and index.client.ts. There is some code in this package that will only work in a Node.JS runtime (e.g., because it depends on the fs pacakge. Entitlements are a good example of this), and other code that is runtime agnostic (e.g., constants.ts). To deal with this, we these two index files export server code and client code, respectively.

For package consumers, the usage would look like the following:

  • Server: import { ... } from @sourcebot/shared
  • Client: import { ... } from @sourcebot/shared/client