mirror of
https://github.com/qodo-ai/pr-agent.git
synced 2025-12-12 19:05:18 +00:00
816ddeeb9e
Hey @mrT23, I thinks there's a problem with moving this line to after `self.git_provider.publish_comment(pr_comment)`. The reason I originally placed it here is because otherwise, if you run `/review --pr_reviewer.remove_previous_review_comment=true` it will publish your review and then immediately after delete it, because it will look for the previous review comment only after you published your new review - so it will take your new review as the previous one. In order to get the real "previous" review you must collect the comments list before publishing a review, so placing this method call first ensures that. The method `self._get_previous_review_comment()` is a no-op if `pr_reviewer.remove_previous_review_comment=false` so I see no downside in keeping it before `self.git_provider.publish_comment(pr_comment)` Additionally, the check for `if previous_review_comment:` is redundant because it's done internally in `self._remove_previous_review_comment`. I thought it looked cleaner without this extra nesting here, but if you think more verbosity is better I'll keep it. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| pr_add_docs.py | ||
| pr_code_suggestions.py | ||
| pr_config.py | ||
| pr_description.py | ||
| pr_generate_labels.py | ||
| pr_information_from_user.py | ||
| pr_questions.py | ||
| pr_reviewer.py | ||
| pr_similar_issue.py | ||
| pr_update_changelog.py | ||