Commit graph

243 commits

Author SHA1 Message Date
mrT23
26cc26129c
Merge pull request #463 from Codium-ai/tr/more_protections
minor fix
2023-11-19 07:45:39 -08:00
mrT23
d1d7903e39
minor fix 2023-11-19 17:44:11 +02:00
mrT23
dff4d1befc
Merge pull request #462 from Codium-ai/tr/more_protections
Enhancements in YAML Parsing and Error Handling
2023-11-19 07:40:06 -08:00
mrT23
83247cadec
protections 2023-11-19 17:30:57 +02:00
mrT23
eb977b4c24
gfm instructions 2023-11-19 11:02:11 +02:00
mrT23
762a6981e1
extra_labels 2023-11-15 14:12:59 +02:00
mrT23
b362c406bc
Merge remote-tracking branch 'origin/main' into tr/review_extra_labels 2023-11-15 14:07:44 +02:00
mrT23
7a342d3312
extra_labels 2023-11-15 14:07:32 +02:00
mrT23
2e95988741
extra_labels 2023-11-15 14:04:17 +02:00
mrT23
9478447141
extra_labels 2023-11-15 14:02:13 +02:00
mrT23
94cb6b9795
more feedback 2023-11-15 09:06:26 +02:00
mrT23
737792d83c
publish_persistent_comment 2023-11-09 15:24:55 +02:00
mrT23
7e5889061c
publish_persistent_comment 2023-11-09 15:20:31 +02:00
mrT23
14610d5375
persistent
s
2023-11-08 20:16:08 +02:00
mrT23
a35a75eb34
get_max_tokens + added 'gpt-4-1106-preview' 2023-11-07 14:28:41 +02:00
Hussam.lawen
ff79776410
Keep user labels 2023-11-06 15:14:08 +02:00
Hussam.lawen
ec3f2fb485
Revert "generate labels keep user labels only"
This reverts commit 94a2a5e527.
2023-11-06 15:08:29 +02:00
Hussam.lawen
94a2a5e527
generate labels keep user labels only 2023-11-06 15:07:06 +02:00
Hussam.lawen
1eefd3365b
Merge commit 'e352c98ce83bfbd99078f62d8705eb938a6ba5b5' into hl/type_vs_labels 2023-11-06 14:24:33 +02:00
Hussam.lawen
db37ee819a
support git providers with no label support 2023-11-06 14:11:49 +02:00
mrT23
e352c98ce8
Merge pull request #431 from Codium-ai/hl/type_vs_labels
Refactoring PR Labels Handling and Display
2023-11-06 02:10:38 -08:00
Hussam.lawen
e96b03da57
add configuration enable_pr_type 2023-11-06 11:58:26 +02:00
Hussam.lawen
1d2aedf169
Don't Display pr labels in the text 2023-11-06 11:35:22 +02:00
mrT23
4c484f8e86
Merge pull request #423 from zmeir/zmeir-external-incremental_review_thresholds
Implementing Thresholds for Incremental PR Reviews
2023-11-06 01:07:01 -08:00
zmeir
8e3fa3926a Extract incremental review checks to separate method 2023-11-06 09:21:22 +02:00
mrT23
fed1c160eb
files walkthrough bullets 2023-11-06 08:43:15 +02:00
mrT23
e37daf6987
link to change 2023-11-06 08:27:34 +02:00
Hussam.lawen
3548b88463
type and labels 2023-11-05 15:48:39 +02:00
zmeir
c623c3baf4 Added new configurations to prevent too frequent incremental commits on push trigger 2023-11-02 12:24:54 +02:00
KennyDizi
9fbf89670d Improve expression portion of f-strings 2023-11-01 19:11:52 +07:00
KennyDizi
ad1c51c536 Fix SyntaxError: f-string expression part cannot include a backslash 2023-11-01 19:06:29 +07:00
Zohar Meir
7b6a6c7164
Fix formatting when last commit message contains _ 2023-10-31 10:05:13 +02:00
Zohar Meir
816ddeeb9e
Fix call to _get_previous_review_comment
Hey @mrT23, I thinks there's a problem with moving this line to after `self.git_provider.publish_comment(pr_comment)`.

The reason I originally placed it here is because otherwise, if you run `/review --pr_reviewer.remove_previous_review_comment=true` it will publish your review and then immediately after delete it, because it will look for the previous review comment only after you published your new review - so it will take your new review as the previous one. In order to get the real "previous" review you must collect the comments list before publishing a review, so placing this method call first ensures that.

The method `self._get_previous_review_comment()` is a no-op if `pr_reviewer.remove_previous_review_comment=false` so I see no downside in keeping it before `self.git_provider.publish_comment(pr_comment)`

Additionally, the check for `if previous_review_comment:` is redundant because it's done internally in `self._remove_previous_review_comment`. I thought it looked cleaner without this extra nesting here, but if you think more verbosity is better I'll keep it.
2023-10-30 09:06:51 +02:00
mrT23
c895657310
fixed review 2023-10-29 17:59:46 +02:00
Ori Kotek
61d3e1ebf4
Merge pull request #394 from zmeir/zmeir-external-push_trigger
Added support for automatic review on push event
2023-10-29 13:04:33 +02:00
mrT23
7374243d0b
enable_custom_labels 2023-10-29 11:40:36 +02:00
mrT23
d772213cfc
fix labels 2023-10-29 08:58:12 +02:00
Hussam.lawen
f53ec1d0cc
move enable custom labels to custom labels function 2023-10-27 21:12:58 +03:00
Hussam.lawen
f3bdbfc103
Add /generate_labels function + fix issues 2023-10-26 23:28:33 +03:00
Zohar Meir
e6bea76eee
Typo 2023-10-26 17:07:16 +03:00
zmeir
02570ea797 Remove previous review comment on push event 2023-10-26 16:46:54 +03:00
zmeir
65bb70a1dd Added support for automatic review on push event
The new feature can be enabled via the new configuration `github_app.handle_push_event`. To avoid any unwanted side-effects, the current default of this configuration is set to `false`.

The high level flow (assuming the configuration is enabled):
1. receive push event from GitHub
2. extract branch and commits from event
3. find PR url for branch (currently does not support PRs from forks)
4. perform configured commands (e.g. `/describe`, `/review -i`)

The push event flow is guarded by a backlog queue so that multiple push events on the same branch won't trigger multiple duplicate runs of the PR-Agent commands.
Example timeline:
1. push 1 - start handling event
2. push 2 - waiting to be handled while push 1 event is still running
3. push 3 - event is dropped since handling it and handling push 2 is the same, so it is redundant
4. push 1 finished being handled
5. push 2 awakens from wait and continues handling (potentially reviewing the commits of both push 2 and push 3)

All of these options are configurable and can be enabled/disabled as per the user's desire.

Additional minor changes in this PR:
1. Created `DefaultDictWithTimeout` utility class to avoid too much boilerplate code in managing caches for outdated triggers.
2. Guard against running increment review when there are no new commits.
3. Minor styling changes for incremented review text.
2023-10-25 11:15:23 +03:00
Hussam.lawen
1a89c7eadf
refactor + add description options 2023-10-24 22:28:57 +03:00
Hussam.lawen
07617eab5a
add custom labels 2023-10-24 22:06:27 +03:00
Hussam.lawen
fa24413201
Custom Labels 2023-10-23 16:29:33 +03:00
mrT23
b6cabda586
quick fix 2023-10-19 17:24:37 +03:00
mrT23
abbce60f18
Merge remote-tracking branch 'origin/main' 2023-10-19 17:10:30 +03:00
mrT23
5daaaf2c1d
quick fix 2023-10-19 17:10:21 +03:00
mrT23
e8f207691e
Merge pull request #391 from Codium-ai/tr/readme
Update and Enhance DESCRIBE.md Documentation
2023-10-19 02:03:50 -07:00
mrT23
b0dce4ceae
describe 2023-10-19 12:02:12 +03:00