Hussam.lawen
ec3f2fb485
Revert "generate labels keep user labels only"
...
This reverts commit 94a2a5e527
2023-11-06 15:08:29 +02:00
Hussam.lawen
94a2a5e527
generate labels keep user labels only
2023-11-06 15:07:06 +02:00
Hussam.lawen
1eefd3365b
Merge commit 'e352c98ce83bfbd99078f62d8705eb938a6ba5b5' into hl/type_vs_labels
2023-11-06 14:24:33 +02:00
Hussam.lawen
db37ee819a
support git providers with no label support
2023-11-06 14:11:49 +02:00
mrT23
e352c98ce8
Merge pull request #431 from Codium-ai/hl/type_vs_labels
...
Refactoring PR Labels Handling and Display
2023-11-06 02:10:38 -08:00
Hussam.lawen
e96b03da57
add configuration enable_pr_type
2023-11-06 11:58:26 +02:00
Hussam.lawen
1d2aedf169
Don't Display pr labels in the text
2023-11-06 11:35:22 +02:00
mrT23
4c484f8e86
Merge pull request #423 from zmeir/zmeir-external-incremental_review_thresholds
...
Implementing Thresholds for Incremental PR Reviews
2023-11-06 01:07:01 -08:00
zmeir
8e3fa3926a
Extract incremental review checks to separate method
2023-11-06 09:21:22 +02:00
mrT23
fed1c160eb
files walkthrough bullets
2023-11-06 08:43:15 +02:00
mrT23
e37daf6987
link to change
2023-11-06 08:27:34 +02:00
Hussam.lawen
3548b88463
type and labels
2023-11-05 15:48:39 +02:00
zmeir
c623c3baf4
Added new configurations to prevent too frequent incremental commits on push trigger
2023-11-02 12:24:54 +02:00
KennyDizi
9fbf89670d
Improve expression portion of f-strings
2023-11-01 19:11:52 +07:00
KennyDizi
ad1c51c536
Fix SyntaxError: f-string expression part cannot include a backslash
2023-11-01 19:06:29 +07:00
Zohar Meir
7b6a6c7164
Fix formatting when last commit message contains _
2023-10-31 10:05:13 +02:00
Zohar Meir
816ddeeb9e
Fix call to _get_previous_review_comment
...
Hey @mrT23, I thinks there's a problem with moving this line to after `self.git_provider.publish_comment(pr_comment)`.
The reason I originally placed it here is because otherwise, if you run `/review --pr_reviewer.remove_previous_review_comment=true` it will publish your review and then immediately after delete it, because it will look for the previous review comment only after you published your new review - so it will take your new review as the previous one. In order to get the real "previous" review you must collect the comments list before publishing a review, so placing this method call first ensures that.
The method `self._get_previous_review_comment()` is a no-op if `pr_reviewer.remove_previous_review_comment=false` so I see no downside in keeping it before `self.git_provider.publish_comment(pr_comment)`
Additionally, the check for `if previous_review_comment:` is redundant because it's done internally in `self._remove_previous_review_comment`. I thought it looked cleaner without this extra nesting here, but if you think more verbosity is better I'll keep it.
2023-10-30 09:06:51 +02:00
mrT23
c895657310
fixed review
2023-10-29 17:59:46 +02:00
Ori Kotek
61d3e1ebf4
Merge pull request #394 from zmeir/zmeir-external-push_trigger
...
Added support for automatic review on push event
2023-10-29 13:04:33 +02:00
mrT23
7374243d0b
enable_custom_labels
2023-10-29 11:40:36 +02:00
mrT23
d772213cfc
fix labels
2023-10-29 08:58:12 +02:00
Hussam.lawen
f53ec1d0cc
move enable custom labels to custom labels function
2023-10-27 21:12:58 +03:00
Hussam.lawen
f3bdbfc103
Add /generate_labels function + fix issues
2023-10-26 23:28:33 +03:00
Zohar Meir
e6bea76eee
Typo
2023-10-26 17:07:16 +03:00
zmeir
02570ea797
Remove previous review comment on push event
2023-10-26 16:46:54 +03:00
zmeir
65bb70a1dd
Added support for automatic review on push event
...
The new feature can be enabled via the new configuration `github_app.handle_push_event`. To avoid any unwanted side-effects, the current default of this configuration is set to `false`.
The high level flow (assuming the configuration is enabled):
1. receive push event from GitHub
2. extract branch and commits from event
3. find PR url for branch (currently does not support PRs from forks)
4. perform configured commands (e.g. `/describe`, `/review -i`)
The push event flow is guarded by a backlog queue so that multiple push events on the same branch won't trigger multiple duplicate runs of the PR-Agent commands.
Example timeline:
1. push 1 - start handling event
2. push 2 - waiting to be handled while push 1 event is still running
3. push 3 - event is dropped since handling it and handling push 2 is the same, so it is redundant
4. push 1 finished being handled
5. push 2 awakens from wait and continues handling (potentially reviewing the commits of both push 2 and push 3)
All of these options are configurable and can be enabled/disabled as per the user's desire.
Additional minor changes in this PR:
1. Created `DefaultDictWithTimeout` utility class to avoid too much boilerplate code in managing caches for outdated triggers.
2. Guard against running increment review when there are no new commits.
3. Minor styling changes for incremented review text.
2023-10-25 11:15:23 +03:00
Hussam.lawen
1a89c7eadf
refactor + add description options
2023-10-24 22:28:57 +03:00
Hussam.lawen
07617eab5a
add custom labels
2023-10-24 22:06:27 +03:00
Hussam.lawen
fa24413201
Custom Labels
2023-10-23 16:29:33 +03:00
mrT23
b6cabda586
quick fix
2023-10-19 17:24:37 +03:00
mrT23
abbce60f18
Merge remote-tracking branch 'origin/main'
2023-10-19 17:10:30 +03:00
mrT23
5daaaf2c1d
quick fix
2023-10-19 17:10:21 +03:00
mrT23
e8f207691e
Merge pull request #391 from Codium-ai/tr/readme
...
Update and Enhance DESCRIBE.md Documentation
2023-10-19 02:03:50 -07:00
mrT23
b0dce4ceae
describe
2023-10-19 12:02:12 +03:00
Hussam Lawen
1b6fb3ea53
Merge pull request #385 from Codium-ai/hl/fix_add_docs_in_scripts
...
Add Blacklist for Non-Editable File Extensions in Documentation
2023-10-19 11:21:36 +03:00
mrT23
a2c3db463a
use_bullet_points
2023-10-19 10:45:42 +03:00
mrT23
d41fe0cf79
comment
2023-10-17 19:45:04 +03:00
Hussam.lawen
3673924fe9
Add docs editable blacklist of file extensions like sql, yaml...
2023-10-17 18:50:39 +03:00
mrT23
d5c098de73
another protection
2023-10-17 10:21:05 +03:00
mrT23
9f5c0daa8e
protection
2023-10-17 09:43:48 +03:00
Ori Kotek
c324d88be3
Refactor logging system to use custom logger across the codebase
2023-10-16 14:56:00 +03:00
mrT23
e2417ebe88
Merge pull request #363 from Codium-ai/tr/pr_suggestions
...
publish each suggestion seperatly only on gitlab
2023-10-08 17:01:44 +03:00
mrT23
e6548f4fe1
simpler solution
2023-10-08 16:57:22 +03:00
mrT23
1b3fb49f9c
publish each suggestion seperatly only on gitlab
2023-10-08 16:50:25 +03:00
Zohar Meir
8f9f09ecbf
Fixed help message for bot user
...
This changes the help message to display properly when running a custom deployment of the PR-Agent app (i.e. not via GitHub Actions, and with the setting `github_app.override_deployment_type=false`)
2023-10-08 16:19:11 +03:00
mrT23
72eecbbf61
add line number
2023-10-05 17:59:08 +03:00
mrT23
989c56220b
add line number
2023-10-05 17:48:36 +03:00
mrT23
088f256415
stable
2023-10-05 17:03:10 +03:00
mrT23
44239f1a79
Patch Extra Lines
2023-10-05 08:38:43 +03:00
Hussam.lawen
e941fa9ec0
Add to user tools guide
2023-10-01 19:51:15 +03:00
Hussam.lawen
ab5ac8ffa8
rename vars + Add to README.md
2023-10-01 13:52:00 +03:00
Hussam.lawen
ccc7f1e10a
rename vars
2023-10-01 13:07:08 +03:00
Hussam.lawen
7fbdc3aead
rstrip
2023-09-28 22:47:26 +03:00
Hussam.lawen
0551922839
Merge commit '663ae92bdf3bb3a22b8b7ab437385c882f96e475' into hl/add_docs
...
# Conflicts:
# pr_agent/tools/pr_add_docs.py
2023-09-28 22:46:07 +03:00
Hussam.lawen
043d453cab
add doc placement before after
2023-09-28 22:44:15 +03:00
Hussam Lawen
663ae92bdf
Add Docs
2023-09-28 22:42:03 +03:00
Hussam.lawen
96824aa9e2
Revert "Add Docs"
...
This reverts commit 5cca299b16
2023-09-28 21:16:14 +03:00
Hussam Lawen
5cca299b16
Add Docs
2023-09-28 21:13:48 +03:00
Hussam.lawen
cd3527f7d4
add configurable docstring style
2023-09-28 20:58:37 +03:00
Hussam.lawen
bb12c75431
reformat
2023-09-28 20:15:18 +03:00
Hussam.lawen
bb8a0f10f4
refine /add_docs
2023-09-28 20:11:18 +03:00
Hussam.lawen
c3cbaaf09e
Initial add docs
2023-09-27 16:48:17 +03:00
mrT23
4c72cfbff4
auto tools in github action
2023-09-25 18:56:10 +03:00
Phill Zarfos
a7fb5d98b1
add get_pr_id() to CodeCommitProvider
2023-09-23 08:08:46 -04:00
mrT23
be54fb5bf8
pr_id
2023-09-21 21:29:41 +03:00
mrT23
632de3f186
protections
2023-09-20 07:39:56 +03:00
mrT23
818ab5a9e8
fixed tests
2023-09-17 16:56:23 +03:00
mrT23
291ffdd6ae
gfm_markdown
2023-09-17 16:51:16 +03:00
mrT23
ea91a38541
Estimated effort to review
2023-09-17 16:31:58 +03:00
mrT23
caaee4e43d
Estimated time to review
2023-09-15 17:09:58 +03:00
mrT23
bba22667f1
merge
2023-09-14 08:13:00 +03:00
mrT23
1b8349b0ef
merge
2023-09-14 07:47:04 +03:00
mrT23
b94e3521d1
Merge remote-tracking branch 'origin/main' into markers
...
# Conflicts:
# pr_agent/tools/pr_description.py
2023-09-14 07:46:30 +03:00
mrT23
9c0656c296
graphic adjustments
2023-09-13 08:16:23 +03:00
mrT23
901eda2f10
logs
2023-09-12 07:57:21 +03:00
Ori Kotek
98d0835c48
Merge remote-tracking branch 'origin/main' into fix_bitbucket_publish_description
2023-09-10 14:08:17 +03:00
Ori Kotek
115b513c9b
Remove 'bitbucket' explicit dependency anywhere that's not in bitbucket_provider.py
2023-09-10 14:06:13 +03:00
mrT23
145b5db458
added 'publish_description_as_comment' support
2023-09-07 12:10:33 +03:00
mrT23
8962c9cf8a
stable
2023-09-06 09:43:23 +03:00
mrT23
bc95cf5b8e
stable
2023-09-06 09:12:25 +03:00
mrT23
901c1dc3f0
issue tool
2023-09-06 08:43:01 +03:00
sarbjitgrewal
335877c4a7
fix publish description for bitbucket
2023-09-06 09:26:23 +05:30
mrT23
c0b23e1091
Merge remote-tracking branch 'origin/main' into tr/issue_tool
...
# Conflicts:
# pr_agent/algo/utils.py
2023-09-05 08:05:33 +03:00
sarbjitgrewal
704c169181
Merge branch 'main' of https://github.com/Codium-ai/pr-agent into fix_bitbucket_improve_issue
2023-09-05 10:00:07 +05:30
Tim Perkins
746140b26e
Add support for markers in description
2023-09-04 12:11:39 -04:00
mrT23
de39595522
Merge pull request #252 from zmeir/zmeir-try_to_fix_split_line_ranges
...
Try to refine the prompt to prevent split line ranges that give bad suggestions
2023-08-31 20:36:33 +03:00
sarbjitgrewal
970a7896e9
Merge branch 'main' of https://github.com/Codium-ai/pr-agent into fix_bitbucket_improve_issue
2023-08-31 13:35:32 +05:30
zmeir
c6c97ac98a
Try to change the improve command prompt to prevent split lines range
2023-08-30 23:33:38 +03:00
zmeir
92e23ff260
Fix #254
2023-08-30 23:05:41 +03:00
sarbjitgrewal
2aaa722102
Merge branch 'main' of https://github.com/Codium-ai/pr-agent into fix_bitbucket_improve_issue
2023-08-29 09:49:19 +05:30
mrT23
2dc2a45e4b
yaml
2023-08-28 09:48:43 +03:00
sarbjitgrewal
39522abc03
fix conflicts
2023-08-28 11:21:47 +05:30
Ori Kotek
355abfc39a
Bitbucket server, WIP
2023-08-24 18:35:41 +03:00
sarbjitgrewal
f0dc485305
Merge branch 'main' of https://github.com/Codium-ai/pr-agent into fix_bitbucket_improve_issue
2023-08-24 16:14:29 +05:30
sarbjitgrewal
db6bf41051
update readme
2023-08-24 15:56:20 +05:30
sarbjitgrewal
67ff50583a
fix improve, update_changelog and review inline comment
2023-08-24 11:52:20 +05:30
mrT23
635b243280
Merge pull request #223 from zmeir/zmeir-keep_original_pr_description
...
Enhancement: Retain Original User Description and Title in PRs
2023-08-22 16:47:16 +03:00
mrT23
f4f040bf8d
publish each suggestion separably
2023-08-22 16:11:51 +03:00
zmeir
82fb611a26
Add options to keep original user title
2023-08-22 10:32:58 +03:00
zmeir
2b22f712fb
Renamed keep_user_description --> add_original_user_description
2023-08-22 09:55:56 +03:00
mrT23
b85679e5e4
improve --extend
2023-08-22 09:42:59 +03:00
mrT23
fb9335f424
extended improve
2023-08-21 18:17:34 +03:00
zmeir
31e91edebc
Allow keeping the original user description
2023-08-20 18:59:40 +03:00
mrT23
6693aa3cbc
semi stable
2023-08-20 15:01:06 +03:00
Ori Kotek
fda98643c2
Merge pull request #217 from sarbjitsinghgrewal/fix_bitbucket_improve_issue
...
fix bitbucket improve issue
2023-08-20 14:42:15 +03:00
sarbjitgrewal
dff4646920
fix bitbucket improve issue
2023-08-18 17:48:45 +05:30
Tim Perkins
631fb93b28
Implement Automatic Review Configuration for GitHub app
2023-08-16 16:24:30 -04:00
Tim Perkins
70286e9574
Make the message more modest
2023-08-15 08:35:57 -04:00
Tim Perkins
3f60d12a9a
Publish comment when improve has no suggestions
2023-08-14 13:07:00 -04:00
mrT23
bb5878c99a
Merge branch 'main' into tr/block_scalar
2023-08-11 18:36:21 +03:00
mrT23
273a9e35d9
block scalar
2023-08-11 18:35:34 +03:00
mrT23
d38c5236dd
Merge pull request #187 from Codium-ai/ok/limit_description
...
Limiting Description and Commit Messages Length
2023-08-09 14:14:47 +03:00
Ori Kotek
e0f295659d
A less hacky way
2023-08-09 12:17:54 +03:00
mrT23
fe75e3f2ec
yaml
...
yaml
2023-08-09 12:15:52 +03:00
Ori Kotek
e3274af831
A (still) hacky way to clip description and commit messages
2023-08-09 10:17:58 +03:00
Ori Kotek
a00038fbd8
Merge remote-tracking branch 'origin/main' into patch-1
2023-08-06 18:09:09 +03:00
mrT23
fed0ea349a
find_line_number_of_relevant_line_in_file
...
find_line_number_of_relevant_line_in_file
2023-08-06 08:13:07 +03:00
Krrish Dholakia
ed8554699b
bug fixes and updates
2023-08-03 16:05:46 -07:00
mrT23
7a57db5d88
load_large_diff is done once
2023-08-03 22:14:05 +03:00
mrT23
c92648cbd5
caching
2023-08-03 21:38:18 +03:00
mrT23
cfa14178f8
Merge pull request #168 from Codium-ai/tr/further_use_commit_messages
...
Use commit messages in PR tools
2023-08-03 07:58:25 +03:00
mrT23
3e94a71dcd
commit_messages_str is used in all tools
2023-08-02 18:26:39 +03:00
zmeir
dd14423b07
Add /config command to list the possible configuration settings
2023-08-02 16:42:54 +03:00
Ori Kotek
c5a79ceedd
Merge remote-tracking branch 'origin/main' into ok/settings_refactor
2023-08-01 16:01:04 +03:00
Ori Kotek
8ae936e504
Bug fixes
2023-08-01 15:58:23 +03:00
mrT23
8c0370a166
Commit messages in pr-description
2023-08-01 15:15:59 +03:00
Ori Kotek
d7b77764c3
Support context aware settings (for each incoming request), support override of settings, refactor CLI to use pr_agent.py
2023-08-01 14:43:26 +03:00
mrT23
e2d015a20c
final
2023-07-30 12:27:32 +03:00
mrT23
42b047a14e
update_settings_from_args
2023-07-30 12:04:57 +03:00
mrT23
3daf94954a
update_settings_from_args
2023-07-30 11:43:44 +03:00
Ori Kotek
b564d8ac32
Merge pull request #147 from zmeir/zmeir-align_describe_styling
...
Minor improvements to describe command
2023-07-28 20:55:15 +03:00
Marshall Yount
ef71a7049e
fix TypeError when iterating discussion_messages
...
When `pr-agent` is reviewing a long list of messages, a TypeError is thrown on the line
```python
for message in reversed(discussion_messages):
```
When reviewing the PyGithub library, the recommend an alternate syntax for iterating a paginated list in reverse.
https://github.com/PyGithub/PyGithub/blob/v1.59.0/github/PaginatedList.py#L122-L125
```
If you want to iterate in reversed order, just do::
for repo in user.get_repos().reversed:
print(repo.name)
```
And here's a copy of the actual traceback
```
Traceback (most recent call last):
File "/app/pr_agent/servers/github_action_runner.py", line 68, in <module>
asyncio.run(run_action())
File "/usr/local/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/usr/local/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/app/pr_agent/servers/github_action_runner.py", line 64, in run_action
await PRAgent().handle_request(pr_url, body)
File "/app/pr_agent/agent/pr_agent.py", line 19, in handle_request
await PRReviewer(pr_url, is_answer=True).review()
File "/app/pr_agent/tools/pr_reviewer.py", line 49, in __init__
answer_str, question_str = self._get_user_answers()
File "/app/pr_agent/tools/pr_reviewer.py", line 253, in _get_user_answers
for message in reversed(discussion_messages):
TypeError: object of type 'PaginatedList' has no len()
```
2023-07-28 11:04:46 +02:00
mrT23
4664d91844
bug fixes in gitlab code suggestion
2023-07-28 11:24:14 +03:00
mrT23
8f16c46012
try-except
2023-07-28 10:52:49 +03:00
zmeir
4aa54b9bd4
Add /describe -c option
2023-07-27 17:42:50 +03:00
zmeir
c6d0bacc08
Match styling of both /describe modes
2023-07-27 17:31:31 +03:00
mrT23
6a72df2981
Merge pull request #139 from Codium-ai/tr/changelog
...
Add feature to update CHANGELOG.md based on PR content
2023-07-27 09:04:48 +03:00
mrT23
808ca48605
if not self.commit_changelog:
2023-07-27 08:48:39 +03:00
mrT23
c827cbc0ae
final touches
2023-07-27 08:47:26 +03:00
mrT23
801923789b
final
2023-07-26 20:33:21 +03:00
mrT23
884317c4f7
stable
2023-07-26 20:03:22 +03:00
mrT23
1bd47b0d53
enhance pr_reviewer.py code
2023-07-26 17:24:03 +03:00
mrT23
7531ccd31f
stable
2023-07-26 16:29:42 +03:00
mrT23
e3846a480e
s
2023-07-26 09:21:31 +03:00
Ori Kotek
adb3f17258
Merge pull request #131 from Codium-ai/ok/gitlab_webook
...
GitLab Webhook Integration and Provider Enhancements
2023-07-24 16:01:17 +03:00
Ori Kotek
2c03a67312
Add labels
2023-07-24 16:00:51 +03:00
mrT23
57ff46ecc1
stable
2023-07-24 12:41:00 +03:00
mrT23
3819d52eb0
Merge remote-tracking branch 'origin/tr/code_enhancment' into tr/code_enhancment
2023-07-24 12:15:17 +03:00
mrT23
3072325d2c
PRDescription
2023-07-24 12:14:53 +03:00
Ori Kotek
abca2fdcb7
Merge remote-tracking branch 'origin/main' into tr/code_enhancment
2023-07-24 12:04:54 +03:00
