Commit graph

211 commits

Author SHA1 Message Date
Zohar Meir
816ddeeb9e
Fix call to _get_previous_review_comment
Hey @mrT23, I thinks there's a problem with moving this line to after `self.git_provider.publish_comment(pr_comment)`.

The reason I originally placed it here is because otherwise, if you run `/review --pr_reviewer.remove_previous_review_comment=true` it will publish your review and then immediately after delete it, because it will look for the previous review comment only after you published your new review - so it will take your new review as the previous one. In order to get the real "previous" review you must collect the comments list before publishing a review, so placing this method call first ensures that.

The method `self._get_previous_review_comment()` is a no-op if `pr_reviewer.remove_previous_review_comment=false` so I see no downside in keeping it before `self.git_provider.publish_comment(pr_comment)`

Additionally, the check for `if previous_review_comment:` is redundant because it's done internally in `self._remove_previous_review_comment`. I thought it looked cleaner without this extra nesting here, but if you think more verbosity is better I'll keep it.
2023-10-30 09:06:51 +02:00
mrT23
c895657310
fixed review 2023-10-29 17:59:46 +02:00
Ori Kotek
61d3e1ebf4
Merge pull request #394 from zmeir/zmeir-external-push_trigger
Added support for automatic review on push event
2023-10-29 13:04:33 +02:00
mrT23
7374243d0b
enable_custom_labels 2023-10-29 11:40:36 +02:00
mrT23
d772213cfc
fix labels 2023-10-29 08:58:12 +02:00
Hussam.lawen
f53ec1d0cc
move enable custom labels to custom labels function 2023-10-27 21:12:58 +03:00
Hussam.lawen
f3bdbfc103
Add /generate_labels function + fix issues 2023-10-26 23:28:33 +03:00
Zohar Meir
e6bea76eee
Typo 2023-10-26 17:07:16 +03:00
zmeir
02570ea797 Remove previous review comment on push event 2023-10-26 16:46:54 +03:00
zmeir
65bb70a1dd Added support for automatic review on push event
The new feature can be enabled via the new configuration `github_app.handle_push_event`. To avoid any unwanted side-effects, the current default of this configuration is set to `false`.

The high level flow (assuming the configuration is enabled):
1. receive push event from GitHub
2. extract branch and commits from event
3. find PR url for branch (currently does not support PRs from forks)
4. perform configured commands (e.g. `/describe`, `/review -i`)

The push event flow is guarded by a backlog queue so that multiple push events on the same branch won't trigger multiple duplicate runs of the PR-Agent commands.
Example timeline:
1. push 1 - start handling event
2. push 2 - waiting to be handled while push 1 event is still running
3. push 3 - event is dropped since handling it and handling push 2 is the same, so it is redundant
4. push 1 finished being handled
5. push 2 awakens from wait and continues handling (potentially reviewing the commits of both push 2 and push 3)

All of these options are configurable and can be enabled/disabled as per the user's desire.

Additional minor changes in this PR:
1. Created `DefaultDictWithTimeout` utility class to avoid too much boilerplate code in managing caches for outdated triggers.
2. Guard against running increment review when there are no new commits.
3. Minor styling changes for incremented review text.
2023-10-25 11:15:23 +03:00
Hussam.lawen
1a89c7eadf
refactor + add description options 2023-10-24 22:28:57 +03:00
Hussam.lawen
07617eab5a
add custom labels 2023-10-24 22:06:27 +03:00
Hussam.lawen
fa24413201
Custom Labels 2023-10-23 16:29:33 +03:00
mrT23
b6cabda586
quick fix 2023-10-19 17:24:37 +03:00
mrT23
abbce60f18
Merge remote-tracking branch 'origin/main' 2023-10-19 17:10:30 +03:00
mrT23
5daaaf2c1d
quick fix 2023-10-19 17:10:21 +03:00
mrT23
e8f207691e
Merge pull request #391 from Codium-ai/tr/readme
Update and Enhance DESCRIBE.md Documentation
2023-10-19 02:03:50 -07:00
mrT23
b0dce4ceae
describe 2023-10-19 12:02:12 +03:00
Hussam Lawen
1b6fb3ea53
Merge pull request #385 from Codium-ai/hl/fix_add_docs_in_scripts
Add Blacklist for Non-Editable File Extensions in Documentation
2023-10-19 11:21:36 +03:00
mrT23
a2c3db463a
use_bullet_points 2023-10-19 10:45:42 +03:00
mrT23
d41fe0cf79
comment 2023-10-17 19:45:04 +03:00
Hussam.lawen
3673924fe9
Add docs editable blacklist of file extensions like sql, yaml... 2023-10-17 18:50:39 +03:00
mrT23
d5c098de73
another protection 2023-10-17 10:21:05 +03:00
mrT23
9f5c0daa8e
protection 2023-10-17 09:43:48 +03:00
Ori Kotek
c324d88be3
Refactor logging system to use custom logger across the codebase 2023-10-16 14:56:00 +03:00
mrT23
e2417ebe88
Merge pull request #363 from Codium-ai/tr/pr_suggestions
publish each suggestion seperatly only on gitlab
2023-10-08 17:01:44 +03:00
mrT23
e6548f4fe1
simpler solution 2023-10-08 16:57:22 +03:00
mrT23
1b3fb49f9c
publish each suggestion seperatly only on gitlab 2023-10-08 16:50:25 +03:00
Zohar Meir
8f9f09ecbf
Fixed help message for bot user
This changes the help message to display properly when running a custom deployment of the PR-Agent app (i.e. not via GitHub Actions, and with the setting `github_app.override_deployment_type=false`)
2023-10-08 16:19:11 +03:00
mrT23
72eecbbf61
add line number 2023-10-05 17:59:08 +03:00
mrT23
989c56220b
add line number 2023-10-05 17:48:36 +03:00
mrT23
088f256415
stable 2023-10-05 17:03:10 +03:00
mrT23
44239f1a79
Patch Extra Lines 2023-10-05 08:38:43 +03:00
Hussam.lawen
e941fa9ec0
Add to user tools guide 2023-10-01 19:51:15 +03:00
Hussam.lawen
ab5ac8ffa8
rename vars + Add to README.md 2023-10-01 13:52:00 +03:00
Hussam.lawen
ccc7f1e10a
rename vars 2023-10-01 13:07:08 +03:00
Hussam.lawen
7fbdc3aead
rstrip 2023-09-28 22:47:26 +03:00
Hussam.lawen
0551922839
Merge commit '663ae92bdf3bb3a22b8b7ab437385c882f96e475' into hl/add_docs
# Conflicts:
#	pr_agent/tools/pr_add_docs.py
2023-09-28 22:46:07 +03:00
Hussam.lawen
043d453cab
add doc placement before after 2023-09-28 22:44:15 +03:00
Hussam Lawen
663ae92bdf
Add Docs 2023-09-28 22:42:03 +03:00
Hussam.lawen
96824aa9e2
Revert "Add Docs"
This reverts commit 5cca299b16.
2023-09-28 21:16:14 +03:00
Hussam Lawen
5cca299b16
Add Docs 2023-09-28 21:13:48 +03:00
Hussam.lawen
cd3527f7d4
add configurable docstring style 2023-09-28 20:58:37 +03:00
Hussam.lawen
bb12c75431
reformat 2023-09-28 20:15:18 +03:00
Hussam.lawen
bb8a0f10f4
refine /add_docs 2023-09-28 20:11:18 +03:00
Hussam.lawen
c3cbaaf09e
Initial add docs 2023-09-27 16:48:17 +03:00
mrT23
4c72cfbff4
auto tools in github action 2023-09-25 18:56:10 +03:00
Phill Zarfos
a7fb5d98b1 add get_pr_id() to CodeCommitProvider 2023-09-23 08:08:46 -04:00
mrT23
be54fb5bf8
pr_id 2023-09-21 21:29:41 +03:00
mrT23
632de3f186
protections 2023-09-20 07:39:56 +03:00