ti.sil/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-12-12 10:55:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

improve: enhance GitLab provider error handling and attribute access safety

Browse source 
- Add try-catch block around GitLab instance creation for better error handling
- Use getattr() for safer attribute access in _prepare_clone_url_with_token method
- Improve authentication failure debugging with clearer error messages
This commit is contained in:
Mr_Jing 2025-08-04 10:35:52 +08:00
parent 2d858a43be
commit dd6f56915b
1 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
pr_agent/git_providers/gitlab_provider.py
View file

@ -39,16 +39,20 @@ class GitLabProvider(GitProvider):
auth_method = self._get_auth_method(gitlab_url) auth_method = self._get_auth_method(gitlab_url)
# Create GitLab instance based on authentication method # Create GitLab instance based on authentication method
if auth_method == "oauth_token": try:
self.gl = gitlab.Gitlab( if auth_method == "oauth_token":
url=gitlab_url, self.gl = gitlab.Gitlab(
oauth_token=gitlab_access_token url=gitlab_url,
) oauth_token=gitlab_access_token
else: # private_token )
self.gl = gitlab.Gitlab( else: # private_token
url=gitlab_url, self.gl = gitlab.Gitlab(
private_token=gitlab_access_token url=gitlab_url,
) private_token=gitlab_access_token
)
except Exception as e:
get_logger().error(f"Failed to create GitLab instance: {e}")
raise ValueError(f"Unable to authenticate with GitLab: {e}")
self.max_comment_chars = 65000 self.max_comment_chars = 65000
self.id_project = None self.id_project = None
self.id_mr = None self.id_mr = None
@ -719,7 +723,7 @@ class GitLabProvider(GitProvider):
get_logger().error(f"Repo URL: {repo_url_to_clone} is not a valid gitlab URL.") get_logger().error(f"Repo URL: {repo_url_to_clone} is not a valid gitlab URL.")
return None return None
(scheme, base_url) = repo_url_to_clone.split("gitlab.") (scheme, base_url) = repo_url_to_clone.split("gitlab.")
access_token = self.gl.oauth_token or self.gl.private_token access_token = getattr(self.gl, 'oauth_token', None) or getattr(self.gl, 'private_token', None)
if not all([scheme, access_token, base_url]): if not all([scheme, access_token, base_url]):
get_logger().error(f"Either no access token found, or repo URL: {repo_url_to_clone} " get_logger().error(f"Either no access token found, or repo URL: {repo_url_to_clone} "
f"is missing prefix: {scheme} and/or base URL: {base_url}.") f"is missing prefix: {scheme} and/or base URL: {base_url}.")