ti.sil/pr-agent
1
0
Fork 0
mirror of https://github.com/qodo-ai/pr-agent.git synced 2025-12-12 02:45:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor reasoning_effort logic for better readability

Browse source 
- Store validation result in variable to avoid redundant checks
- Add warning log when invalid reasoning_effort value is configured
- Improve source tracking in info log
- Makes code more maintainable and easier to debug
This commit is contained in:
Tyler Zhang 2025-12-08 09:37:55 +08:00
parent eb2f432e16
commit 956f3660f2
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
pr_agent/algo/ai_handlers/litellm_ai_handler.py
View file

@ -297,20 +297,28 @@ class LiteLLMAIHandler(BaseAiHandler):
# Note: gpt-5.1 supports 'none', but gpt-5.1-codex does not # Note: gpt-5.1 supports 'none', but gpt-5.1-codex does not
config_effort = get_settings().config.reasoning_effort config_effort = get_settings().config.reasoning_effort
supported_efforts = ['none', 'low', 'medium', 'high'] supported_efforts = ['none', 'low', 'medium', 'high']
is_config_valid = config_effort in supported_efforts
source = "config"
if model.endswith('_thinking'): if is_config_valid:
# For thinking models, use config value or default to 'low' effort = config_effort
effort = config_effort if config_effort in supported_efforts else 'low'
else: else:
# For non-thinking models, use config value or default to 'none' source = "default"
# If 'none' fails for specific models (e.g., codex), they should set config to 'low' if config_effort is not None:
effort = config_effort if config_effort in supported_efforts else 'none' get_logger().warning(
f"Invalid reasoning_effort '{config_effort}' in config. "
f"Using default. Supported values: {supported_efforts}"
)
if model.endswith('_thinking'):
effort = 'low'
else:
effort = 'none'
thinking_kwargs_gpt5 = { thinking_kwargs_gpt5 = {
"reasoning_effort": effort, "reasoning_effort": effort,
"allowed_openai_params": ["reasoning_effort"], "allowed_openai_params": ["reasoning_effort"],
} }
get_logger().info(f"Using reasoning_effort={effort} for GPT-5 model (from {'config' if config_effort in supported_efforts else 'default'})") get_logger().info(f"Using reasoning_effort='{effort}' for GPT-5 model (from {source})")
model = 'openai/'+model.replace('_thinking', '') # remove _thinking suffix model = 'openai/'+model.replace('_thinking', '') # remove _thinking suffix