From 14c6f8bf806261b87b1b7ed8a8e47ece329e6d01 Mon Sep 17 00:00:00 2001 From: expruc Date: Mon, 21 Jul 2025 21:18:37 +0300 Subject: [PATCH 1/2] added a check for admins to avoid 404 errors on feedbacks get and post --- backend/open_webui/routers/evaluations.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/backend/open_webui/routers/evaluations.py b/backend/open_webui/routers/evaluations.py index 164f3c40b4..e99cbe56ca 100644 --- a/backend/open_webui/routers/evaluations.py +++ b/backend/open_webui/routers/evaluations.py @@ -129,7 +129,10 @@ async def create_feedback( @router.get("/feedback/{id}", response_model=FeedbackModel) async def get_feedback_by_id(id: str, user=Depends(get_verified_user)): - feedback = Feedbacks.get_feedback_by_id_and_user_id(id=id, user_id=user.id) + if user.role == 'admin': + feedback = Feedbacks.get_feedback_by_id(id=id) + else: + feedback = Feedbacks.get_feedback_by_id_and_user_id(id=id, user_id=user.id) if not feedback: raise HTTPException( @@ -143,9 +146,12 @@ async def get_feedback_by_id(id: str, user=Depends(get_verified_user)): async def update_feedback_by_id( id: str, form_data: FeedbackForm, user=Depends(get_verified_user) ): - feedback = Feedbacks.update_feedback_by_id_and_user_id( - id=id, user_id=user.id, form_data=form_data - ) + if user.role == 'admin': + feedback = Feedbacks.update_feedback_by_id(id=id, form_data=form_data) + else: + feedback = Feedbacks.update_feedback_by_id_and_user_id( + id=id, user_id=user.id, form_data=form_data + ) if not feedback: raise HTTPException( From 1ff2ad0c08c4587999a143a15f23fa111d9c0e4e Mon Sep 17 00:00:00 2001 From: expruc Date: Mon, 21 Jul 2025 22:17:08 +0300 Subject: [PATCH 2/2] ci fix --- backend/open_webui/routers/evaluations.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/open_webui/routers/evaluations.py b/backend/open_webui/routers/evaluations.py index e99cbe56ca..c76a1f6915 100644 --- a/backend/open_webui/routers/evaluations.py +++ b/backend/open_webui/routers/evaluations.py @@ -129,7 +129,7 @@ async def create_feedback( @router.get("/feedback/{id}", response_model=FeedbackModel) async def get_feedback_by_id(id: str, user=Depends(get_verified_user)): - if user.role == 'admin': + if user.role == "admin": feedback = Feedbacks.get_feedback_by_id(id=id) else: feedback = Feedbacks.get_feedback_by_id_and_user_id(id=id, user_id=user.id) @@ -146,7 +146,7 @@ async def get_feedback_by_id(id: str, user=Depends(get_verified_user)): async def update_feedback_by_id( id: str, form_data: FeedbackForm, user=Depends(get_verified_user) ): - if user.role == 'admin': + if user.role == "admin": feedback = Feedbacks.update_feedback_by_id(id=id, form_data=form_data) else: feedback = Feedbacks.update_feedback_by_id_and_user_id(