enh: more info in feedback modal

This commit is contained in:
Timothy Jaeryang Baek 2025-06-30 15:38:25 +04:00
parent 71d550dd26
commit a14cfb6448
2 changed files with 100 additions and 35 deletions

View file

@ -3,16 +3,41 @@
import { getContext } from 'svelte'; import { getContext } from 'svelte';
const i18n = getContext('i18n'); const i18n = getContext('i18n');
import XMark from '$lib/components/icons/XMark.svelte'; import XMark from '$lib/components/icons/XMark.svelte';
import { getFeedbackById } from '$lib/apis/evaluations';
import { toast } from 'svelte-sonner';
import Spinner from '$lib/components/common/Spinner.svelte';
export let show = false; export let show = false;
export let selectedFeedback = null; export let selectedFeedback = null;
export let onClose: () => void = () => {}; export let onClose: () => void = () => {};
let loaded = false;
let feedbackData = null;
const close = () => { const close = () => {
show = false; show = false;
onClose(); onClose();
}; };
const init = async () => {
loaded = false;
feedbackData = null;
if (selectedFeedback) {
feedbackData = await getFeedbackById(localStorage.token, selectedFeedback.id).catch((err) => {
toast.error(err);
return null;
});
console.log('Feedback Data:', selectedFeedback, feedbackData);
}
loaded = true;
};
$: if (show) {
init();
}
</script> </script>
<Modal size="sm" bind:show> <Modal size="sm" bind:show>
@ -28,20 +53,33 @@
</div> </div>
<div class="flex flex-col md:flex-row w-full px-5 pb-4 md:space-x-4 dark:text-gray-200"> <div class="flex flex-col md:flex-row w-full px-5 pb-4 md:space-x-4 dark:text-gray-200">
{#if loaded}
<div class="flex flex-col w-full"> <div class="flex flex-col w-full">
<div class="mb-2 -mx-1"> {#if feedbackData}
{#if selectedFeedback?.data?.tags && selectedFeedback?.data?.tags.length} {@const messageId = feedbackData?.meta?.message_id}
<div class="flex flex-wrap gap-1 mt-1"> {@const messages = feedbackData?.snapshot?.chat?.chat?.history.messages}
{#each selectedFeedback?.data?.tags as tag}
<span class="px-2 py-0.5 rounded-full bg-gray-100 dark:bg-gray-850 text-xs" {#if messages[messages[messageId]?.parentId]}
>{tag}</span <div class="flex flex-col w-full mb-2">
> <div class="mb-1 text-xs text-gray-500">{$i18n.t('Prompt')}</div>
{/each}
<div class="flex-1 text-xs whitespace-pre-line break-words">
<span>{messages[messages[messageId]?.parentId]?.content || '-'}</span>
</div>
</div> </div>
{:else}
<span>-</span>
{/if} {/if}
{#if messages[messageId]}
<div class="flex flex-col w-full mb-2">
<div class="mb-1 text-xs text-gray-500">{$i18n.t('Response')}</div>
<div
class="flex-1 text-xs whitespace-pre-line break-words max-h-32 overflow-y-auto"
>
<span>{messages[messageId]?.content || '-'}</span>
</div> </div>
</div>
{/if}
{/if}
<div class="flex flex-col w-full mb-2"> <div class="flex flex-col w-full mb-2">
<div class=" mb-1 text-xs text-gray-500">{$i18n.t('Rating')}</div> <div class=" mb-1 text-xs text-gray-500">{$i18n.t('Rating')}</div>
@ -58,6 +96,28 @@
</div> </div>
</div> </div>
<div class="flex flex-col w-full mb-2">
<div class=" mb-1 text-xs text-gray-500">{$i18n.t('Comment')}</div>
<div class="flex-1 text-xs">
<span>{selectedFeedback?.data?.comment || '-'}</span>
</div>
</div>
<div class="mb-2 -mx-1">
{#if selectedFeedback?.data?.tags && selectedFeedback?.data?.tags.length}
<div class="flex flex-wrap gap-1 mt-1">
{#each selectedFeedback?.data?.tags as tag}
<span class="px-2 py-0.5 rounded-full bg-gray-100 dark:bg-gray-850 text-[9px]"
>{tag}</span
>
{/each}
</div>
{:else}
<span>-</span>
{/if}
</div>
<div class="flex justify-end pt-2"> <div class="flex justify-end pt-2">
<button <button
class="px-3.5 py-1.5 text-sm font-medium bg-black hover:bg-gray-900 text-white dark:bg-white dark:text-black dark:hover:bg-gray-100 transition rounded-full" class="px-3.5 py-1.5 text-sm font-medium bg-black hover:bg-gray-900 text-white dark:bg-white dark:text-black dark:hover:bg-gray-100 transition rounded-full"
@ -68,6 +128,11 @@
</button> </button>
</div> </div>
</div> </div>
{:else}
<div class="flex items-center justify-center w-full h-32">
<Spinner className={'size-5'} />
</div>
{/if}
</div> </div>
</div> </div>
{/if} {/if}

View file

@ -77,7 +77,7 @@
let showLeaderboardModal = false; let showLeaderboardModal = false;
let selectedModel = null; let selectedModel = null;
const openFeedbackModal = (model) => { const openLeaderboardModelModal = (model) => {
showLeaderboardModal = true; showLeaderboardModal = true;
selectedModel = model; selectedModel = model;
}; };
@ -505,7 +505,7 @@
{#each sortedModels as model, modelIdx (model.id)} {#each sortedModels as model, modelIdx (model.id)}
<tr <tr
class="bg-white dark:bg-gray-900 dark:border-gray-850 text-xs group cursor-pointer hover:bg-gray-50 dark:hover:bg-gray-850/50 transition" class="bg-white dark:bg-gray-900 dark:border-gray-850 text-xs group cursor-pointer hover:bg-gray-50 dark:hover:bg-gray-850/50 transition"
on:click={() => openFeedbackModal(model)} on:click={() => openLeaderboardModelModal(model)}
> >
<td class="px-3 py-1.5 text-left font-medium text-gray-900 dark:text-white w-fit"> <td class="px-3 py-1.5 text-left font-medium text-gray-900 dark:text-white w-fit">
<div class=" line-clamp-1"> <div class=" line-clamp-1">